Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: read ECONNRESET on react-native when i refresh storybook-native browser tab with react-native 0.53 #2923

Closed
macrozone opened this issue Feb 6, 2018 · 7 comments
Assignees

Comments

@macrozone
Copy link
Contributor

macrozone commented Feb 6, 2018

Issue details

refreshing browser window crashes storybook-native with latest storybook version and react-native 0.53

Steps to reproduce

  • start storybook storybook start -p 7007
  • open app on device
  • open chrome tab on localhost:7007
  • refresh that tab with cmd+r
  • storybook will crash with "Error: read ECONNRESET"

Please specify which version of Storybook and optionally any affected addons that you're running

  • @storybook/react-native": "^3.3.12"
  • react-native: 0.53.0
events.js:183
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at _errnoException (util.js:1024:11)
    at TCP.onread (net.js:615:25)
error Command failed with exit code 1.
@axelnormand
Copy link

Same here and I can't figure out what's causing it.
Something hot reload?

@macrozone macrozone changed the title Error: read ECONNRESET on react-native when i refresh storybook-native browser tab Error: read ECONNRESET on react-native when i refresh storybook-native browser tab with react-native 0.53 Feb 6, 2018
@sabbox
Copy link

sabbox commented Feb 9, 2018

Environment:
  OS: macOS High Sierra 10.13.2

Packages: (wanted => installed)
  react: 16.2.0 => 16.2.0
  react-native: 0.53.0 => 0.53.0

"@storybook/react-native": "3.3.12"

same thing,
also did experience same behaviour on react-native 0.52

@nikhedonia
Copy link

nikhedonia commented Feb 14, 2018

I was able to work around this bug by forcing ws package to version3.3.2.
I've used yarn resolutions to accomplish this.

further information: websockets/ws#1256

@axelnormand
Copy link

Many thanks @nikhedonia the ws downgrade seems to have worked a treat for me.
Also thanks for the link to the underlying issue documenting the change in ws error behaviour in 3.3.3

@Hypnosphi
Copy link
Member

Hypnosphi commented Feb 21, 2018

Released 3.3.14

@axelnormand you can remove the downgrade now

@nikhedonia
Copy link

nikhedonia commented Feb 21, 2018

Thank you guys!
I can confirm it works for us in newsuk/times-components.

@axelnormand
Copy link

works great. Many thanks @Hypnosphi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants