RN: Add error handler on WS to fix crashing on page reload

[Hypnosphi]

Issue: #2923

What I did

Added error handling according to websockets/ws#1256 (comment)

How to test

Launch CRNA example, refresh desktop browser tab (it should be Chrome)

[lpinca]

This will also catch connection errors like ECONNREFUSED, not sure if wanted.

[Hypnosphi]

What would be the proper filter to only catch chrome tab reload?

[lpinca]

Is WebSocket here the browser native WebSocket object or ws or it depends on the context?

[lpinca]

I think this is the browser WebSocket as per https://github.com/storybooks/storybook/pull/3002/files#diff-432fa23ac718b94ed5be1b2802371d41R3. In this case you don't need this, the fix on the server is sufficient and correct.

[codecov]

Codecov Report

Merging #3002 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3002      +/-   ##
==========================================
- Coverage    37.3%   37.29%   -0.02%     
==========================================
  Files         435      435              
  Lines        9432     9435       +3     
  Branches      883      896      +13     
==========================================
  Hits         3519     3519              
- Misses       5379     5394      +15     
+ Partials      534      522      -12

Impacted Files	Coverage Δ
app/react-native/src/server/index.js	0% <0%> (ø)	⬆️
app/vue/src/server/config/babel.js	0% <0%> (-100%)	⬇️
app/vue/src/server/utils.js	0% <0%> (-100%)	⬇️
app/react/src/server/babel_config.js	0% <0%> (-76.67%)	⬇️
lib/ui/src/modules/ui/components/layout/index.js	29.28% <0%> (ø)	⬆️
app/react-native/src/bin/storybook-build.js	0% <0%> (ø)	⬆️
addons/actions/src/lib/util/typeReviver.js	71.42% <0%> (ø)	⬆️
lib/ui/src/modules/ui/containers/shortcuts_help.js	25% <0%> (ø)	⬆️
addons/knobs/src/angular/utils.js	82.14% <0%> (ø)	⬆️
addons/storyshots/src/angular/renderTree.js	61.9% <0%> (ø)	⬆️
... and 48 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4741632...dba45e5. Read the comment docs.

[danielduan]

saw you denied the two screenshot changes. is that because of the async nature of screenshots or is this PR not ready to go yet?

[tmeasday]

Apologies again about these flaky tests. I hope to have it sorted out in the next 24-48 hours. More than happy to revert the PR that added them in the meantime.

[danielduan]

@tmeasday does the screenshots happen when document.ready or is there some sort of timer that gets triggered? I think the screenshots here look like they're taken too early.

There was one I just fixed in my other PR where the early blank screenshot was set as the correct test set. I don't think it's a huge issue but maybe your other customers might mind if the timing is off.

[tmeasday]

@danielduan in this case it is due to the stories rendering an iframe, which we then need to wait to load. You can read more detail about what's happening here: #2958

[nikhedonia]

could you someone publish 3.3.14 to npm? - many thanks

[Hypnosphi]

It's actually published:
https://www.npmjs.com/package/@storybook/react-native

3.3.14 is the latest of 73 releases

If you're behind a corporate proxy, you may need to wait until it updates its cache