Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addon-info: defaultProps strings shows two sets of quotes #3324

Closed
teddybradford opened this issue Mar 31, 2018 · 2 comments
Closed

addon-info: defaultProps strings shows two sets of quotes #3324

teddybradford opened this issue Mar 31, 2018 · 2 comments
Assignees
@danielduan
Labels
addon: info bug

Comments

@teddybradford
Copy link

Bug summary

The default string values for PropTypes show up with 2 sets of surrounding quotes.

Versions

  • storybook/react: 4.0.0-alpha.1
  • storybook/addon-info: 4.0.0-alpha.1

Screenshot

image

Button.propTypes = {
  size: PropTypes.string,
  color: PropTypes.string
};

Button.defaultProps = {
  size: "default",
  color: "primary"
};
danielduan added a commit that referenced this issue Apr 11, 2018
@danielduan
#3324 fix double quotes in prop table and add additional examples
b145800
@danielduan danielduan mentioned this issue Apr 11, 2018
Merged
@danielduan danielduan removed the todo label Apr 11, 2018
@danielduan danielduan self-assigned this Apr 11, 2018
danielduan added a commit that referenced this issue Apr 12, 2018
@danielduan
#3324 fix double quotes in prop table and add additional examples
bb28679
danielduan added a commit that referenced this issue Apr 12, 2018
@danielduan
Merge pull request #3401 from storybooks/dd/docgen-prop-table
8c2f644 
#3324 fix double quotes in prop table and add additional examples
@Hypnosphi
Copy link
Member

Released as 4.0.0-alpha.3

Hypnosphi pushed a commit that referenced this issue May 17, 2018
@danielduan @Hypnosphi
Merge pull request #3401 from storybooks/dd/docgen-prop-table
1b4976b 
#3324 fix double quotes in prop table and add additional examples
@Hypnosphi
Copy link
Member

Released as 3.4.5

@dependencies dependencies bot mentioned this issue Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielduan danielduan

Labels
addon: info bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danielduan @teddybradford @Hypnosphi