Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSX files not resolved #35

Closed
tomitrescak opened this issue Apr 3, 2016 · 6 comments
Closed

JSX files not resolved #35

tomitrescak opened this issue Apr 3, 2016 · 6 comments

Comments

@tomitrescak
Copy link
Contributor

I'm creating a spearate issue following on #33 when it is not possible to use typescript with storybook as jsx files are not resolved and storybook is concerned only with js files. Here is what I attempted yet it does not work:

const path = require('path');
module.exports = {
  module: {
    resolve: {
      extensions: ['', '.js', '.jsx']
    },
    loaders: [
      {
        test: /\.jsx?$/,
        loader: 'babel',
        query: { presets: ['react', 'es2015', 'stage-2'] },
        exclude: [path.resolve('./node_modules'), path.resolve(__dirname, 'node_modules')],
        include: [path.resolve('./'), __dirname],
      },
      {
        test: /\.css?$/,
        loaders: [ 'style', 'raw' ],
        include: path.resolve(__dirname, '../')
      }
    ]
  }
};
@arunoda
Copy link
Member

arunoda commented Apr 3, 2016

There is a PR for JSX and I will take it as soon week started.

So, what about the type script, I didn't get it.

@tomitrescak
Copy link
Contributor Author

Not much, just adding a .d.ts definition will help typescript developers write typescript rich stories.

@tomitrescak
Copy link
Contributor Author

If the PR will work we can close this.

@arunoda
Copy link
Member

arunoda commented Apr 3, 2016

So you mean you got it configured for type script properly?

@tomitrescak
Copy link
Contributor Author

No, it does not resolve jsx files currently .. will wait for your PR.

@arunoda
Copy link
Member

arunoda commented Apr 3, 2016

Will do it ASAP, I get to the office.

ndelangen pushed a commit that referenced this issue Apr 5, 2017
ndelangen pushed a commit that referenced this issue Apr 11, 2017
Use the branch url for notes addon
ndelangen pushed a commit that referenced this issue Apr 11, 2017
Add a confirm box when deleting components. #35
ndelangen added a commit that referenced this issue Apr 13, 2017
ndelangen pushed a commit that referenced this issue Apr 23, 2017
thani-sh pushed a commit that referenced this issue May 24, 2017
Don't run Travis in master branch
ndelangen pushed a commit that referenced this issue Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants