Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block page navigations and make them as actions #7

Closed
arunoda opened this issue Mar 29, 2016 · 3 comments
Closed

Block page navigations and make them as actions #7

arunoda opened this issue Mar 29, 2016 · 3 comments
Labels
feature request

Comments

@arunoda
Copy link
Member

arunoda commented Mar 29, 2016

When clicked on a HREF we need to prevent any page navigation. Instead we need to fire an action.
@smeijer
Copy link

smeijer commented Jul 16, 2016

Is there already a workaround available for this?

@smeijer
Copy link

smeijer commented Nov 2, 2016

Anybody?

ndelangen pushed a commit that referenced this issue Apr 5, 2017
@arunoda
Merge pull request #7 from ritz078/feat/fuzzy-search
4340c80 
Added fuzzy search
ndelangen pushed a commit that referenced this issue Apr 5, 2017
@arunoda
Merge pull request #7 from kadirahq/better-default-stories
7695825 
Add better default stories
ndelangen pushed a commit that referenced this issue Apr 5, 2017
@roonyh
Merge pull request #7 from kadirahq/use-add-decorator
7583cfd 
Use add decorator
ndelangen added a commit that referenced this issue Apr 5, 2017
@ndelangen
Merge pull request #7 from storybooks/add-storyshots-repo
b971846 
Add storyshots repo
ndelangen pushed a commit that referenced this issue Apr 5, 2017
Merge pull request #7 from kadirahq/props-in-source-code
c03919d 
Props in source code
ndelangen pushed a commit that referenced this issue Apr 5, 2017
Merge pull request #7 from kadirahq/greenkeeper-update-all
efc777e 
Update all dependencies 🌴
ndelangen pushed a commit that referenced this issue Apr 11, 2017
Merge pull request #7 from kadirahq/greenkeeper-update-all
ceb05ce 
Update all dependencies 🌴
( 0 files changed :/ )
ndelangen pushed a commit that referenced this issue Apr 11, 2017
Merge pull request #7 from kadirahq/greenkeeper-react-15.3.2
b92890e 
react@15.3.2 untested ⚠️
ndelangen pushed a commit that referenced this issue Apr 11, 2017
@arunoda
Merge pull request #13 from kadirahq/fix-7
f76f3c7 
Remove full date #7
ndelangen pushed a commit that referenced this issue Apr 11, 2017
Merge pull request #7 from storybooks/remove-babel-cli
03a5cd3 
Remove unused dependency
ndelangen pushed a commit that referenced this issue Apr 15, 2017
Merge pull request #7 from storybooks/work-in-iframe
cb891ff 
Identify the page using a param
ndelangen pushed a commit that referenced this issue May 11, 2017
Merge pull request #7 from kadirahq/greenkeeper-react-15.3.2
4fbb9d5 
react@15.3.2 untested ⚠️
@ndelangen
Copy link
Member

ndelangen commented Jul 7, 2017 •
edited
Loading

I don't really agree this should be default storybook behavior.

If a component has a <a href... that's what the component is and does.
Overriding this without explicit configuration to do so, would be super unexpected.

I'm guessing it's rather easy to write an addon that will preventDefault() any click within it, and log an action. But I haven't seen such an addon yet, so I'm really wondering if this is something we should write.

If you want this comment below or make a PR :)

@ndelangen ndelangen mentioned this issue Jul 7, 2017
Closed
ndelangen pushed a commit that referenced this issue Nov 11, 2017
@jrwebdev @ndelangen
Update to use Storybook v3. Closes #7
980468b
@dependencies dependencies bot mentioned this issue Sep 18, 2018
Closed
igor-dv pushed a commit that referenced this issue Nov 5, 2018
@Stephanemw
Merge pull request #7 from storybooks/master
34d4899 
update from master
ndelangen pushed a commit that referenced this issue Apr 16, 2019
@ndelangen
#7: Add type annotation for withContexts story decorator
db38c9e
leoyli pushed a commit that referenced this issue Apr 17, 2019
#7: Add type annotation for withContexts story decorator
bc346f5
leoyli pushed a commit that referenced this issue Apr 17, 2019
#7: Add type annotation for withContexts story decorator
c4caa21
leoyli pushed a commit that referenced this issue Apr 18, 2019
#7: Add type annotation for withContexts story decorator
5b26a9c
leoyli pushed a commit that referenced this issue Apr 18, 2019
#7: Add type annotation for withContexts story decorator
6be4d4c
leoyli pushed a commit that referenced this issue Apr 18, 2019
#7: Add type annotation for withContexts story decorator
793c92b
leoyli pushed a commit that referenced this issue Apr 18, 2019
#7: Add type annotation for withContexts story decorator
8767e98
leoyli pushed a commit that referenced this issue Apr 18, 2019
#7: Add type annotation for withContexts story decorator
8cfe888
ghengeveld added a commit that referenced this issue Sep 8, 2021
@ghengeveld
Merge pull request #7 from storybookjs/rerun-tool
c7610a7 
"Rerun story" tool
ndelangen pushed a commit that referenced this issue Feb 23, 2024
@valentinpalkovic
Merge pull request #7 from storybookjs/valentin/confetti-wrapper
0b11d0c 
Implement bare minimum confetti component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arunoda @smeijer @ndelangen