Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming stories in MDX fails to remove old story #7169

Closed
kylesuss opened this issue Jun 21, 2019 · 2 comments
Closed

Renaming stories in MDX fails to remove old story #7169

kylesuss opened this issue Jun 21, 2019 · 2 comments

Comments

@kylesuss
Copy link
Contributor

Describe the bug

When using .mdx to compose stories on the latest alpha release (5.2.0-alpha.29), renaming a story has the effect of creating a newly named story in the currently running storybook, but the old story and name still exists in the UI.

To Reproduce

  1. Using 5.2.0-alpha.29, add a story as simple as the following:
import { Story, Meta } from '@storybook/addon-docs/blocks';

<Meta title="Test" />

<Story name="testing">
  <div>Test</div>
</Story>
  1. Fire up storybook
  2. Change the name of the story to anything other than the current name
  3. Verify in the UI that the story for testing still exists

Expected behavior
When renaming a story using JS, storybook refreshes the list of available stories and maintains an up to date catalog of the stories that are available. I would expect the behavior to be consistent between the two approaches.

Screenshots
docs-mdx-name

Code snippets
If applicable, add code samples to help explain your problem.

System:

  • OS: MacOS
  • Device: Macbook Pro 2019
  • Browser: Chrome
  • Framework: react
  • Version: 5.2.0-alpha.29
@shilman
Copy link
Member

shilman commented Jul 8, 2019

Egads!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-alpha.37 containing PR #7319 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

@shilman
Copy link
Member

shilman commented Jul 31, 2019

Yowza!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.1.10 containing PR #7319 that references this issue. Upgrade today to try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants