Addon-docs: Fix renaming stories on module / MDX format #7319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
bug
patch:yes
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-7169-fix-renaming-stories.storybook.now.sh |
shilman
changed the title
ndelangen
reviewed
Jul 5, 2019
| @@ -271,6 +280,13 @@ export default class StoryStore extends EventEmitter { | |||
| removeStoryKind(kind) { | |||
| if (this.hasStoryKind(kind)) { | |||
| this._legacydata[toKey(kind)].stories = {}; | |||
|
|
|||
| this._data = Object.entries(this._data).reduce((acc, [id, story]) => { | |||
There was a problem hiding this comment.
I feel a fear of recursion if both api's call each other..
There was a problem hiding this comment.
Fortunately they don't -- they just modify the data structures directly?
ndelangen
approved these changes
Jul 5, 2019
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Jul 31, 2019
Addon-docs: Fix renaming stories on module / MDX format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7169
What I did
Update story_store to keep _data and _legacydata in sync.
NOTE: we should deprecate _legacydata functions and remove them
How to test
Also
Then edit a story name in
addon-docs.stories.mdxand observe that it updates as expected in the UI.