-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed prop type: The prop children
is marked as required in Td
, but its value is undefined
.
#7195
Comments
same in 5.1.0-rc.0 |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
I'm experiencing this same issue
|
FYI |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Having this same issue here, except I can reproduce it with a single story in my storybook, I will provide the code for it below but this is the only story in my book that will cause the error on page load (refresh). ImageLoader.jsimport React, { useState } from "react";
import { useAxiosMock } from "../../helpers";
import { storiesOf } from "@storybook/react";
import { select, text, button, number } from "@storybook/addon-knobs";
import { ImageLoader, FlexBox, PropTable } from "../";
import readme from "./ImageLoader.md";
const stories = storiesOf("Components", module);
const src = "http://localhost:9009/myImage.png";
const Story = () => {
const [key, setKey] = useState(0);
const options = {
200: 200,
404: 404
};
let serverResponse = select("Server response", options, 200);
useAxiosMock(
axiosMock => {
axiosMock.onGet(src).reply(config => [serverResponse, "OK"]);
},
[serverResponse]
);
const bgSizeOptions = {
cover: "cover",
contain: "contain"
};
const aspectRatioOptions = {
"16:9": "16:9",
"4:3": "4:3",
"1:1": "1:1"
};
const style = {
width: "200px"
};
return (
<FlexBox alignItems="flex-start" col>
<FlexBox id="test" style={style}>
<ImageLoader
key={key}
src={src}
fallback={text("Fallback message", "Fallback message")}
initialRetryDelay={1000}
backgroundColor="light_gray4"
border="imageBorder"
maxRetries={number("Maximum retries", 2)}
aspectRatio={select("Aspect ratio", aspectRatioOptions, "16:9")}
backgroundSize={select("Background size", bgSizeOptions, "contain")}
/>
</FlexBox>
<br />
{button("Rerender", () => setKey(k => k + 1))}
</FlexBox>
);
};
stories.add("ImageLoader", () => <Story />, {
readme: {
// Show readme at the addons panel
sidebar: readme
},
info: {
propTables: [ImageLoader],
// TableComponent: PropTable
}
}); I'll start by saying this is not my component and I am not here to review it, I merely want to fix this specific issue (TL:DR; I don't need styling suggestions). My effort to resolve the issue so farI have created a custom You've got a fix then mate, why are you here?I probably wouldn't be here but I am unable to set and use the custom table at the global level (I.e. if I add |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
same in |
PRs welcome |
Yee-haw!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-alpha.42 containing PR #8745 that references this issue. Upgrade today to try it out! You can find this prerelease on the Closing this issue. Please re-open if you think there's still more to do. |
Yowza!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.6 containing PR #8745 that references this issue. Upgrade today to try it out! |
Describe the bug
Updated from storybook 4 to 5. This warning appears in the console when first loading the page. On visiting other 'stories' warning doesn't show up.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
No warnings should appear in console.
Screenshots
N/A
Code snippets
N/A
System:
Additional context
package.json:
The text was updated successfully, but these errors were encountered: