Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-info: Fix "The prop 'children' is marked as required in 'Td'" #8745

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Addon-info: Fix "The prop 'children' is marked as required in 'Td'" #8745

merged 1 commit into from
Nov 8, 2019

Conversation

hobroker
Copy link
Contributor

@hobroker hobroker commented Nov 7, 2019

Issue: #7195

What I did

Make children prop in the Td component as optional and added it to the defaultProps

@vercel
Copy link

vercel bot commented Nov 7, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/2617wbyjs
🌍 Preview: https://monorepo-git-fork-hobroker-7195-addon-info-fix.storybook.now.sh

@vercel vercel bot requested a deployment to staging November 7, 2019 09:44 Abandoned
@vercel
Copy link

vercel bot commented Nov 7, 2019

Deployment failed with the following error:

ENOENT: no such file or directory, stat '/tmp/YxC0mFMicQzcCdXC83VKcuCJ/repo/examples/official-storybook/built-storybooks/angular-cli'

@hobroker hobroker mentioned this pull request Nov 7, 2019
Closed
@ndelangen ndelangen changed the base branch from master to next November 7, 2019 11:06
@ndelangen ndelangen self-assigned this Nov 7, 2019
@ndelangen
Copy link
Member

Thanks for the PR @hobroker, this looks good.

We use the next branch as the default branch, If you could rebase your commits on that branch, I can merge it today.

@hobroker hobroker closed this Nov 7, 2019
@hobroker hobroker deleted the 7195-addon-info-fix branch November 7, 2019 12:03
@hobroker hobroker restored the 7195-addon-info-fix branch November 7, 2019 12:04
@hobroker
Copy link
Contributor Author

hobroker commented Nov 7, 2019

Sorry for this

@hobroker hobroker reopened this Nov 7, 2019
@hobroker hobroker closed this Nov 7, 2019
@vercel vercel bot temporarily deployed to staging November 7, 2019 21:23 Inactive
@hobroker hobroker reopened this Nov 7, 2019
@shilman shilman added addon: info bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Nov 8, 2019
shilman
shilman approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit d660bb6 into storybookjs:next Nov 8, 2019
@hobroker hobroker deleted the 7195-addon-info-fix branch November 8, 2019 07:01
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 9, 2019
shilman added a commit that referenced this pull request Nov 9, 2019
@shilman
Addon-info: Fix "The prop 'children' is marked as required in '… (#8745)
ce8342a 
Addon-info: Fix "The prop 'children' is marked as required in 'Td'"
This was referenced Nov 18, 2019
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 30, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@dangreenisrael dangreenisrael Awaiting requested review from dangreenisrael

@theinterned theinterned Awaiting requested review from theinterned

@usulpro usulpro Awaiting requested review from usulpro

@z4o4z z4o4z Awaiting requested review from z4o4z

@aaronmcadam aaronmcadam Awaiting requested review from aaronmcadam

@igor-dv igor-dv Awaiting requested review from igor-dv

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees

@ndelangen ndelangen

Labels
addon: info bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hobroker @ndelangen @shilman