-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs: Multi-component props tables on DocsPage #7811
Comments
addon-docs
How would you feel about a primary |
@shilman I think that would be a great option! My only thought on it being an array vs object was related to naming of the prop tables. Would those only be based on display name, or should that be configurable? |
I'm open to making it an object; that's a great idea. I first wanted to get buy-in on the idea that there can be a "primary" component for a page, and potentially other "auxiliary" components. It seems like this is the case, but I want to understand peoples' use cases to make sure. |
We also have this issue, as use the component/subComponent pattern a lot, in our case with dot notation, e.g.
An optional |
Fixed in #8855 and released in https://github.com/storybookjs/storybook/releases/tag/v5.3.0-beta.2 🔥 🔥 🔥 |
ZOMG!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-beta.9 containing PR #8931 that references this issue. Upgrade today to try it out! You can find this prerelease on the |
Is your feature request related to a problem? Please describe.
For many of our composed components, my team uses exports such as
import Card, { CardActions } from @team/project/Card;
, but our stories are then only on the top levelCard
. This is not currently supported.Describe the solution you'd like
.addParameters({ component: Card })
=>.addParameters({ components: { Card, CardActions } })
Describe alternatives you've considered
The current alternative would probably be to use a dummy story that links to the top level from each of the sub-components
Are you able to assist bring the feature to reality?
Yes, but I would need some pointers
The text was updated successfully, but these errors were encountered: