Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocsPage: Add subcomponents parameter #8813

Closed
wants to merge 4 commits into from
Closed

DocsPage: Add subcomponents parameter #8813

wants to merge 4 commits into from

Conversation

enagy27
Copy link
Contributor

@enagy27 enagy27 commented Nov 12, 2019

Issue: #7811

What I did

Added subcomponents parameter to DocsPage to allow named props tables

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes, TODO
  • Does this need a new example in the kitchen sink apps? Yes, TODO
  • Does this need an update to the documentation? Yes, TODO

@vercel
Copy link

vercel bot commented Nov 12, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/hn5ysj1oj
🌍 Preview: https://monorepo-git-fork-enagy27-addon-docs-subcomponents.storybook.now.sh

@shilman shilman changed the title - Added subcomponents parameter to DocsPage DocsPage: Add subcomponents parameter Nov 17, 2019
@shilman
Copy link
Member

shilman commented Nov 17, 2019

@domyen So I tried this out in a simple example and realized that it needs some design. Here's what the simple example looks like:

Addons___Docs___ButtonGroup_-_Basic_⋅_Storybook

And here's a real-world example from evergarden-ui/evergarden#6 that I think is pretty representative. This Alert component also has AlertIcon, AlertTitle, AlertDescription subcomponents which are not currently shown:

Alert_-_Defaults_⋅_Storybook

cc @enagy27 @patricklafrance @Aaron-Pool

@patricklafrance
Copy link
Member

@shilman
Copy link
Member

shilman commented Nov 19, 2019

@enagy27 This ended up getting fixed in #8855, so I'm going to close this. Thanks so much for taking the initiative on this -- I'll include your work in the release post, even tho the code itself didn't make it in!

@shilman shilman closed this Nov 19, 2019
@enagy27
Copy link
Contributor Author

enagy27 commented Nov 19, 2019

@shilman sounds great! I’m just glad to have it, thanks for the heads up 😄

@enagy27 enagy27 deleted the addon-docs/subcomponents branch November 19, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants