Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix source-map strategy for production #10290

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Core: Fix source-map strategy for production #10290

merged 1 commit into from
Apr 3, 2020

Conversation

ndelangen
Copy link
Member

Issue: #9901

What I did

How to test

  • start in devmode (source-maps should work)
  • make a static build, host static build (source-maps should work)

@ndelangen ndelangen added this to the 6.0 milestone Apr 2, 2020
@ndelangen ndelangen self-assigned this Apr 2, 2020
@ndelangen
Copy link
Member Author

WDYT ?

@DanielHoffmann
@rey-wright

shilman
shilman approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman changed the title CHANGE source-map strategy for production Core: Fix source-map strategy for production Apr 3, 2020
@shilman shilman merged commit d4027f0 into next Apr 3, 2020
@shilman shilman deleted the fix/9901 branch April 3, 2020 03:07
@rey-wright
Copy link

sorry for looking at this so late. Looks good! Thanks so much.

@shilman shilman mentioned this pull request Apr 7, 2020
Closed
@shilman shilman mentioned this pull request Jun 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@ndelangen ndelangen

Labels
bug configuration babel / webpack
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ndelangen @rey-wright @shilman