Fix: build-storybook no longer supports relative paths #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes storybookjs#1052 I've tested this locally and it resolves the issue I encountered.
ndelangen
approved these changes
May 18, 2017
|
@ajhyndman Thank you so much for helping us out! 👏 |
|
That was quick! Thanks for being so responsive! |
ndelangen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #1052
I've tested this locally and it resolves the issue I described above.
What I did
Resolve the output path passed in CLI config to an absolute path before handing it to Webpack.
How to test
When using
@storybook/react@3.0.0-alpha.0in a project, run: