Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: html stories homogenization #10705

Merged
merged 4 commits into from
May 14, 2020
Merged

cli: html stories homogenization #10705

merged 4 commits into from
May 14, 2020

Conversation

tooppaaa
Copy link
Contributor

@tooppaaa tooppaaa commented May 9, 2020

Issue:

We need similar stories after generation to run e2e against

Part of #10702

@tooppaaa tooppaaa added maintenance User-facing maintenance tasks cli html labels May 9, 2020
@tooppaaa tooppaaa mentioned this pull request May 9, 2020
13 tasks
@yannbf yannbf mentioned this pull request May 10, 2020
2 tasks
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! only a simple thing to change

lib/cli/src/generators/HTML/index.js Outdated Show resolved Hide resolved
…g `sb init` in an html project

`@storybook/addons` is already a dependency of all `@storybook/addon-XXX` packages so there is no need to add it to the root project directly.
@gaetanmaisse gaetanmaisse requested a review from yannbf May 14, 2020 05:41
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff!

@yannbf yannbf merged commit 6c4a57b into next May 14, 2020
@gaetanmaisse gaetanmaisse deleted the generator_html branch May 14, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli html maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants