CLI: Remove CRA fixtures from Yarn 2 tests run #10720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaetanmaisse
force-pushed
the
fix-yarn-2-cli-tests
branch
from
5225403 to
ea57fb2
Compare
gaetanmaisse
added
cli
maintenance
gaetanmaisse
changed the title
react_scripts_ts fixture
gaetanmaisse
requested review from
ndelangen,
shilman and
stijnkoopal
as code owners
When testing Yarn 2 compatibility of Storybook CLI, we are using Yarn 2 in fixture directories inside a Yarn 1 workspace. To access local versions of `@storybook` packages we use Yarn 2 `portal` protocol (see berryfy_package_json.js). However, it looks like CRA is not playing well with `portal` protocol and is throwing this kind of error: `Relative imports outside of src/ are not supported.`. As new E2E tests will be soon available, I just removed the CRA tests instead of trying to hack them a bit more.
gaetanmaisse
force-pushed
the
fix-yarn-2-cli-tests
branch
from
ea57fb2 to
37f29dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When testing Yarn 2 compatibility of Storybook CLI, we are using Yarn 2 in fixture directories inside a Yarn 1 workspace. To access local versions of
@storybookpackages we use Yarn 2portalprotocol.However, it looks like CRA is not playing well with
portalprotocol and is throwing this kind of error:Relative imports outside of src/ are not supported..As new E2E tests will be soon available - see #10702, I just removed the CRA tests (that are always 🔴) instead of trying to hack them a bit more.