[fix] - Detect local addons for windows machines #10786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuneKR
changed the title
ndelangen
approved these changes
May 14, 2020
ndelangen
added
bug
patch:yes
|
That's actually a smart solution! |
|
Hi @ndelangen i realised i missed updating the test https://github.com/RuneKR/storybook/blob/next/lib/core/src/server/presets.test.js#L400 Do you want me to fix that and also do another PR for 5.x? I assume this PR got released in 6.x |
shilman
pushed a commit
that referenced
this pull request
Jul 7, 2020
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Local addons do not work on windows see issue
What I did
I updated the local compare function to use the fs package to check if the file exists. Seemed to be the most simple solution. Wrong local paths to files that do not exists will now be interpreted as not being local files.
How to test
Note
Would like to get this change into a 5.x if possible. Can do another PR on that.