Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Eval argTypes default value #10812

Merged
merged 3 commits into from
May 17, 2020
Merged

Addon-docs: Eval argTypes default value #10812

merged 3 commits into from
May 17, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented May 17, 2020 •
edited
Loading

Issue: #10497

What I did

Docgen produces default value as a string. We need to eval the string 🙈 to get the actual default value.

Self-merging @ndelangen @patricklafrance

How to test

See the ArgsStory DocsPage before and after the change

@shilman shilman requested a review from usulpro as a code owner May 17, 2020 09:20
@shilman shilman added this to the 6.0 args milestone May 17, 2020
@shilman shilman added the bug label May 17, 2020
@shilman shilman merged commit 45b67d7 into next May 17, 2020
@shilman shilman mentioned this pull request May 17, 2020
Closed
@anicholls anicholls mentioned this pull request Jan 11, 2021
Open
@stof stof deleted the 10497-argtypes-default-values branch May 25, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usulpro usulpro Awaiting requested review from usulpro

@patricklafrance patricklafrance Awaiting requested review from patricklafrance

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees
No one assigned
Labels
addon: docs args bug
Projects
None yet
Milestone
6.0 args
Development

Successfully merging this pull request may close these issues.
1 participant
@shilman