Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX refs not authenticating #10819

Merged
merged 3 commits into from
May 19, 2020
Merged

FIX refs not authenticating #10819

merged 3 commits into from
May 19, 2020

Conversation

ndelangen
Copy link
Member

What I did

When refs are behind a authenticated page, the checkRef api should:

  • add credentials
  • pass content-type

@ndelangen ndelangen added this to the 6.0 milestone May 18, 2020
@ndelangen ndelangen requested a review from tmeasday May 18, 2020 08:47
@ndelangen ndelangen self-assigned this May 18, 2020
tmeasday
tmeasday requested changes May 18, 2020
View reviewed changes
lib/api/src/modules/refs.ts Outdated Show resolved Hide resolved
@ndelangen ndelangen requested a review from tmeasday May 19, 2020 10:25
@ndelangen ndelangen merged commit e23ff36 into next May 19, 2020
@ndelangen ndelangen deleted the fix/ref-auth branch May 19, 2020 11:29
@ndelangen ndelangen mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees

@ndelangen ndelangen

Labels
bug composition
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @tmeasday