Fix: upgrade and add some missing dependencies in core, router, api #10825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building `@storybook/api` we are generating types that are based on `@types/reach__router` (see in dist/index.d.ts: `location: import("@reach/router").WindowLocation<{}>`).
And as in the monorepo we have the latest version of `@types/reach__router` we are using generic version of `WindowLocation` added by DefinitelyTyped/DefinitelyTyped@4109455
So we need to update the required version of `@types/reach__router` in the dependency otherwise users can try to run SB with an old version of `@types/reach__router` and face the following error:
```
ERROR in /.../my-project/node_modules/@storybook/api/dist/index.d.ts(75,19):
TS2315: Type 'WindowLocation' is not generic.
```
I also updated the version in `@storybook/router` to be consistent across the different packages.
gaetanmaisse
commented
May 18, 2020
| "@types/node" "*" | ||
|
|
||
| "@types/puppeteer@^2.0.0": | ||
| "@types/puppeteer@*", "@types/puppeteer@^2.0.0": |
gaetanmaisse
added
bug
maintenance
All theses deps have been used in `@storybook/core` in #10725 But haven't been properly added as dependencies.
gaetanmaisse
force-pushed
the
fix-required-version-of-reach-router-types
branch
from
452b483 to
52f7f4e
Compare
gaetanmaisse
changed the title
@types/reach__router
gaetanmaisse
changed the title
gaetanmaisse
changed the title
ndelangen
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When building
@storybook/apiwe are generating types that are based on@types/reach__router(see in dist/index.d.ts:location: import("@reach/router").WindowLocation<{}>).And as in the monorepo we have the latest version of
@types/reach__routerwe are using generic version ofWindowLocationadded by DefinitelyTyped/DefinitelyTyped@4109455So we need to update the required version of
@types/reach__routerin the dependency otherwise users can try to run SB with an old version of@types/reach__router(like I did when upgrading to the latest beta 😁) and face the following error 💥 :I also updated the version in
@storybook/routerto be consistent across the different packages.--
Also, added some missing dependencies in
@storybook/core, making SB fails with Yarn 2. Related to #10725.How to test