Core: Fix CRA filter for built-in webpack settings #10861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
reviewed
May 21, 2020
mrmckeb
force-pushed
the
feature/fix-cra-filter
branch
from
1f16b0e to
0df35b4
Compare
shilman
added
bug
core
cra
shilman
changed the title
|
@mrmckeb can you figure out the breaking e2e test? |
mrmckeb
force-pushed
the
feature/fix-cra-filter
branch
from
0835867 to
3a5ba8a
Compare
mrmckeb
force-pushed
the
feature/fix-cra-filter
branch
from
3a5ba8a to
0270cd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
Fixed an issue where the CRA preset filter only applied when the preset was an object.
How to test
Run the examples in the project. They should work correctly.