Angular: Support workspace.json
in nx workspace
#10881
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
Nx is a tool for managing a monorepo that can contain any kind of javascript framework. Nx has its own CLI based on the angular CLI, but we also allow the root
angular.json
file to be namedworkspace.json
for non-angular devs to be more comfortable. However, the@storybook/angular
package will only look for theangular.json
file. This PR checks forangular.json
and falls back toworkspace.json
. If neither file is present, the same error appears.How to test
npx create-nx-workspace storybook-with-workspace-json --preset=empty --cli=nx cd storybook-with-workspace-json yarn add @nrwl/angular @nrwl/storybook npx nx g @nrwl/angular:ng-add npx nx g @nrwl/angular:lib ui --no-interactive npx nx g @schematics/angular:component --name=button --project=ui --no-interactive npx nx g @nrwl/angular:storybook-configuration --name=ui --generateStories --no-interactive npx nx run ui:storybook
You'll see an error that
angular.json
was not found. After this PR, the error doesn't show up.