Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Args: Add optional scalar test cases for typescript #11149

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 12, 2020

Issue: #11146

What I did

Tried to reproduce #11146 in a standalone test case

How to test

See attached test case & chromatic changes

@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2020

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against 74b9764

@stale
Copy link

stale bot commented Jul 3, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jul 3, 2020
@stale stale bot removed the inactive label Jul 30, 2020
@shilman shilman marked this pull request as ready for review July 30, 2020 05:07
@shilman
Copy link
Member Author

shilman commented Jul 30, 2020

self-merging

@shilman shilman merged commit 0feb784 into next Jul 30, 2020
@shilman shilman added the maintenance User-facing maintenance tasks label Jul 30, 2020
@stof stof deleted the 11146-typescript-optional-props branch May 25, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: controls args maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant