Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: use addon-essentials & args #11282

Merged
merged 27 commits into from
Jul 1, 2020
Merged

CLI: use addon-essentials & args #11282

merged 27 commits into from
Jul 1, 2020

Conversation

tooppaaa
Copy link
Contributor

@tooppaaa tooppaaa commented Jun 23, 2020 •
edited
Loading

Issue: #10795

What I did

  • Update stories to use args and follow new pattern with .bind({})
  • Prepare addon-controls

How to test

  • E2E

@tooppaaa tooppaaa requested a review from shilman June 23, 2020 20:45
@shilman shilman self-assigned this Jun 24, 2020
@tooppaaa tooppaaa force-pushed the feature/essentialsCLI branch from 3188e1a to 00a0179 Compare June 24, 2020 21:32
@tooppaaa tooppaaa marked this pull request as ready for review June 26, 2020 06:26
@tooppaaa
Copy link
Contributor Author

@ndelangen I've not set back () => action('onClick')() to be closer from what's auto generated for some frameworks. Would that be an issue ?

@tooppaaa tooppaaa requested a review from danielduan as a code owner June 26, 2020 09:27
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Jun 26, 2020
@ndelangen ndelangen added this to the 6.0 milestone Jun 26, 2020
@ndelangen ndelangen force-pushed the feature/essentialsCLI branch from 8cb5755 to 3d8434a Compare June 26, 2020 17:59
@tooppaaa tooppaaa mentioned this pull request Jun 30, 2020
Closed
4 tasks
@ndelangen ndelangen merged commit 17e6afc into next Jul 1, 2020
@ndelangen ndelangen deleted the feature/essentialsCLI branch July 1, 2020 09:51
@shilman shilman mentioned this pull request Jul 2, 2020
Closed
4 tasks
@yannbf yannbf mentioned this pull request Jul 2, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman Awaiting requested review from shilman

@igor-dv igor-dv Awaiting requested review from igor-dv

@ndelangen ndelangen Awaiting requested review from ndelangen

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal

@danielduan danielduan Awaiting requested review from danielduan

Assignees

@shilman shilman

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tooppaaa @shilman @ndelangen