Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate addParameters and addDecorator #11417

Merged
merged 3 commits into from
Jul 5, 2020
Merged

Deprecate addParameters and addDecorator #11417

merged 3 commits into from
Jul 5, 2020

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jul 4, 2020

Issue: Note on #10005 (comment)

What I did

Deprecated addParameters/addDecorators

How to test

Try offical SB, see now warning. Try other SBs, they will probably warn ;)

@tmeasday tmeasday added the maintenance User-facing maintenance tasks label Jul 4, 2020
@tmeasday tmeasday requested a review from shilman July 4, 2020 07:13
shilman
shilman requested changes Jul 4, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

MIGRATION.md Outdated Show resolved Hide resolved
@tmeasday @shilman
Update MIGRATION.md
05ad240 
Co-authored-by: Michael Shilman <shilman@users.noreply.github.com>
shilman
shilman approved these changes Jul 5, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit ca9fb16 into next Jul 5, 2020
@shilman shilman mentioned this pull request Jul 5, 2020
Closed
@haworku haworku mentioned this pull request Dec 22, 2020
Merged
@dptoot dptoot mentioned this pull request Jan 6, 2022
Closed
@stof stof deleted the 10005-deprecate-addParameters-addDecorator branch May 25, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@usulpro usulpro Awaiting requested review from usulpro

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman