Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Speed up combineParameters #11736

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Core: Speed up combineParameters #11736

merged 4 commits into from
Jul 30, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 30, 2020 •
edited
Loading

Issue: #11732

What I did

  • Memoize getStoriesForKind (4x speedup for DocsPage) <= causes tests to break
  • Speed up combineParameters by maximally reusing existing objects (~2.5x speedup over lodash/merge-based approach, which copies objects needlessly)

How to test

Let's see what the tests say

@shilman shilman added this to the 6.0 milestone Jul 30, 2020
@shilman shilman requested a review from ndelangen July 30, 2020 15:28
@shilman shilman changed the title Core: Speed up render/combineParameters slowness Core: Speed up combineParameters Jul 30, 2020
@shilman
Copy link
Member Author

shilman commented Jul 30, 2020

Self-merging @tmeasday @ndelangen

@shilman shilman merged commit 3481971 into next Jul 30, 2020
@shilman shilman mentioned this pull request Jul 30, 2020
Closed
2 tasks
@tmeasday
Copy link
Member

👏 👏 👏 👏

@stof stof deleted the 11732-fix-render-slowness branch August 4, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees
No one assigned
Labels
bug core performance issue
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday