Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Add STORY_SPECIFIED event for initial sidebar selection/URL #11766

Merged
merged 4 commits into from
Aug 3, 2020

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Aug 3, 2020

Issue: #11764

What I did

No longer respond to CURRENT_STORY_WAS_SET in manager as it is too hard to tell if it is out of date.

Instead, add a new event STORY_SPECIFIED which only applies to the first story selected.

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes
  • Does this need a new example in the kitchen sink apps?

Try things in OfficialSB

@tmeasday tmeasday changed the title Add a new STORY_SPECIFIED event and use to drive the menu Add a new STORY_SPECIFIED event and use to drive the initial sidebar selection/URL Aug 3, 2020
@tmeasday tmeasday requested a review from shilman August 3, 2020 04:48
@shilman shilman added this to the 6.0 milestone Aug 3, 2020
@shilman shilman changed the title Add a new STORY_SPECIFIED event and use to drive the initial sidebar selection/URL Core: Add STORY_SPECIFIED event for initial sidebar selection/URL Aug 3, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit dee5c3e into next Aug 3, 2020
@stof stof deleted the 11764-fix-startup-delay branch May 25, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants