-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a vanilla React Native example app. #1202
Conversation
Thanks CodeFactor! I tried to work around https://www.codefactor.io/repository/github/storybooks/storybook/pull/1202 but could not :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please give me a chance to review before merging 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmeasday you need to add this to lerna.json
to ignore for both publish
and bootstrap
. We don't want to publish it. For bootstrap, it fails if I run a clean bootstrap
from the root. But if I go to the RN app directory and npm install
it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep all folder-names lowercase and dash separated ?
React Native wouldn't let me pass such a name into it. I'm scared to change it after the fact ;) [I'll try] |
39892ea
to
2357c8f
Compare
Ok, made the changes requested |
Codecov Report
@@ Coverage Diff @@
## master #1202 +/- ##
==========================================
- Coverage 13.72% 13.32% -0.41%
==========================================
Files 207 199 -8
Lines 4611 4585 -26
Branches 520 618 +98
==========================================
- Hits 633 611 -22
+ Misses 3523 3444 -79
- Partials 455 530 +75
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!!
@tmeasday build is failing in minor ways |
d8436a8
to
481f2c9
Compare
For #1012. Includes storyshots and the use of addon-options
Although RN uses Jest for testing, it uses a Jest preset which messes with the environment. AFIACT it's not possible to selectively apply the environment to different tests so we just separate them.
4d84f7e
to
616a46d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue: We need an example app for RN! #1012
What I did
How to test
npm install
.npm run storybook
+react-native run-ios
. Check the stories are displayed and thename
option works.npm test
, ensure 3 snapshots are recorded.