Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating and optimizing circleCI Config #12118

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Conversation

PK1312
Copy link
Contributor

@PK1312 PK1312 commented Aug 18, 2020

What I did

Made some changes (along with @ KyleTryon ) to the config file in order to increase the performance and decrease credit usage, primarily via the usage of different size executors. Also wrote a framework for more easily specifying the executor and size in the config file. These changes, though small, should add up to fewer consumed credits.

How to test

Passing CI tests should be all that is required

Made some changes (along with @ KyleTryon ) to the config file in order to increase the performance and decrease credit usage, primarily via the usage of different size executors. Also wrote a framework for more easily specifying the executor and size in the config file. These changes, though small, should add up to fewer consumed credits.
@PK1312 PK1312 requested a review from ndelangen as a code owner August 18, 2020 20:45
@shilman shilman added the maintenance User-facing maintenance tasks label Aug 19, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit f2a1fc5 into storybookjs:next Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants