Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-viewport: Add preset to fix windows import #12148

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

tooppaaa
Copy link
Contributor

Issue: #12024

For windows users, addons that are missing preset are not loaded through essentials

What I did

Add preset to viewport

How to test

@tooppaaa tooppaaa requested a review from saponifi3d as a code owner August 19, 2020 21:18
@tooppaaa
Copy link
Contributor Author

tooppaaa commented Aug 19, 2020

@gaetanmaisse I do not explain this behavior...

My feeling would telll me that require.resolve a path without export would do nothing on windows.
This is very weird but only explanation I've got so far 😞

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tho technically this is a workaround and it would be better if we can find the underlying cause

@shilman shilman merged commit 62200c6 into next Aug 20, 2020
@stof stof deleted the fix/viewportAndEssentials branch May 25, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants