Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Fix inline rendering for DOM nodes in HTML #12164

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Addon-docs: Fix inline rendering for DOM nodes in HTML #12164

merged 1 commit into from
Aug 20, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 20, 2020

Issue: #12138

What I did

Update HTML inline renderer to handle DOM nodes instead of just assuming HTML

How to test

See the DocsPage Demo/Button story in html-kitchen-sink

@shilman shilman added this to the 6.0.x milestone Aug 20, 2020
tmeasday
tmeasday approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@shilman shilman merged commit ff5f480 into next Aug 20, 2020
@shilman shilman mentioned this pull request Aug 20, 2020
Closed
@stof stof deleted the 12138-html-fix-inline-rendering branch May 25, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
addon: docs bug html
Projects
None yet
Milestone
6.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday