Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document stories not showing up on storybook UI until device connects #1221

Merged
merged 3 commits into from
Jun 9, 2017
Merged

Document stories not showing up on storybook UI until device connects #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86405f7
Document stories not showing up on storybook UI until device connects
shilman Jun 8, 2017
cc55510
Merge branch 'master' into improve-rn-welcome
shilman Jun 8, 2017
eb15170
Merge branch 'master' into improve-rn-welcome
shilman Jun 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/react-native/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ Now, you can open <http://localhost:7007> to view your storybook menus in the br

## Start App

To see your Storybook stories on the device, you should start your mobile app for the `<platform>` of your choice (typically `ios` or `android`).
To see your Storybook stories on the device, you should start your mobile app for the `<platform>` of your choice (typically `ios` or `android`). (Note that due to an implementation detail, your stories will only show up in the left-pane after your device has connected to this storybook server.)

For CRNA apps:

Expand Down
4 changes: 3 additions & 1 deletion app/react-native/src/manager/components/PreviewHelp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ const PreviewHelp = () =>
{' '}
<span style={styles.code}>&lt;platform&gt;</span>
{' '}
of your choice (typically ios or android).
of your choice (typically ios or android). (Note that due to an implementation detail, your
stories will only show up in the left-pane after your device has connected to this storybook
server.)
</p>
<p>
For <span style={styles.code}>create-react-native-app</span> apps:
Expand Down