Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update documentation for issue #12513 #12774

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Chore: Update documentation for issue #12513 #12774

merged 1 commit into from
Oct 15, 2020

Conversation

jonniebigodes
Copy link
Contributor

With this pull request the issue #12513 is addressed.

What was done:

  • Updated the @storybook/addon-storyshots to include information about the customization of the snapshot directory.
  • Updated the Snapshot (workflows/snapshot-testing) page to address the issue with an example.
  • Included a snippet for the configuration

@GasimGasimzada and @latviancoder if you both also could take a look at this as you are involved parties i would greatly appreciate any feedback you're willing to offer to fine tune it.

@shilman let me know as well if you're ok with it

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 14, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit ed960bf into next Oct 15, 2020
@shilman shilman deleted the fix_issue_12513 branch October 15, 2020 08:26
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 16, 2020
shilman added a commit that referenced this pull request Oct 16, 2020
Chore: Update documentation for issue #12513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants