Storyshots: Add missing vue peer dependencies #12790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This section should probably be updated as this is not the case anymore storybook/addons/storyshots/storyshots-core/README.md Lines 253 to 255 in 9da7db7 |
merceyz
force-pushed
the
merceyz/storyshots
branch
from
ce01bd6 to
cf25fba
Compare
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@storybook/addon-storyshotsis trying to usevueand@storybook/vuewithout declaring them as dependenciesWhat I did
Added them as optional peer dependencies
How to test
Try to use
@storybook/addon-storyshotswith vue in a Yarn PnP project