Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composition: Append index to ref indicator links #12932

Merged
merged 1 commit into from
Nov 1, 2020
Merged

Composition: Append index to ref indicator links #12932

merged 1 commit into from
Nov 1, 2020

Conversation

marksmccann
Copy link
Contributor

@marksmccann marksmccann commented Oct 27, 2020 •
edited
Loading

Issue: #12659

What I did

Appended index.html to links in the ref indicator flyout – in order to support storybook apps nested in a URL directory (e.g. domain.com/mystorybookapp/index.html)

How to test

  • Is this testable with Jest or Chromatic screenshots? No?
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

@shilman shilman added this to the 6.1 composition milestone Oct 28, 2020
@shilman shilman changed the title Append index to ref indicator links Composition: Append index to ref indicator links Nov 1, 2020
@shilman shilman merged commit caae314 into storybookjs:next Nov 1, 2020
@shilman shilman mentioned this pull request Nov 1, 2020
Closed
@marksmccann marksmccann deleted the issue-12659 branch November 1, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@ndelangen ndelangen

Labels
composition feature request
Projects
None yet
Milestone
6.1 composition
Development

Successfully merging this pull request may close these issues.
3 participants
@marksmccann @ndelangen @shilman