CLI: use Jest to test CLI commands and remove outdated fixtures

[jamesgeorge007]

What I did

• Removed CLI test fixtures.
• Leverage Jest for e2e tests.

closes #13318

[jamesgeorge007]

Running smoke-test in sfc_vue directory exhibits an inconsistent behavior.

Starting storybook manually works fine (process completes with exit code 0):-

It fails when invoked via jest:-

/cc @shilman @ndelangen

[gaetanmaisse]

Thanks for the PR @jamesgeorge007 💪🏻

I just pushed a small commit to fix a path, broken after a directory move, and left a few comments.
Can you take a look at them? Let me know if something is unclear :)

I will take a look at the sfc_vue case 🤔

[gaetanmaisse]

@jamesgeorge007 I'm focusing on another PR for now but will take a new look at this one soon ;)

[gaetanmaisse]

Found the issue with some fixtures! I will add commits to fix that in the next few days :)

[gaetanmaisse]

#13231 should fix things but a new error appeared, I'm investigating a bit more 🔍

[gaetanmaisse]

CLI tests are back to 🟢 on next so it should be here too. Can you update the branch?

To get the full result of the tests and not stop at the first failing one is really great 🎉 !

I think one more thing we need to improve is maybe how the underlying error/logs can be catch and display clearly in Jest test result. To have something more meaningful than:

    expect(received).toBe(expected) // Object.is equality

    Expected: 0
    Received: 1

[jamesgeorge007]

Running smoke-test in the sfc_vue directory is still failing.

[gaetanmaisse]

I discussed with @ndelangen and @shilman and it looks like all the fixtures are outdated. And so the result of these tests aren't really relevant nor reflect if Storybook properly works or not. As keeping up to date the fixtures is very time-consuming and as we have more robust e2e tests, it looks like we will remove these ones: #13318.

I'm a bit disappointed to tell you that although you have spent time to them 😕

[gaetanmaisse]

🚀

[gaetanmaisse]

@shilman can I merge this one or are we still merging only PRs stabilizing 6.1?

[ndelangen]

should be good to merge to next IMHO