Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify bug that show header when not use header #1297

Closed
wants to merge 1 commit into from
Closed

Modify bug that show header when not use header #1297

wants to merge 1 commit into from

Conversation

uyeong
Copy link

@uyeong uyeong commented Jun 16, 2017

Issue:

What I did

I have modified bug that show header when not use header.

How to test

When I pass header: false of options, header is displayed

2017-06-16 6 15 56

So I have modified code like below image.

2017-06-16 6 37 46

@codecov
Copy link

codecov bot commented Jun 16, 2017

Codecov Report

Merging #1297 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1297   +/-   ##
=======================================
  Coverage   13.76%   13.76%           
=======================================
  Files         201      201           
  Lines        4620     4620           
  Branches      506      498    -8     
=======================================
  Hits          636      636           
- Misses       3538     3564   +26     
+ Partials      446      420   -26
Impacted Files Coverage Δ
addons/info/src/components/Story.js 0% <ø> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/left_panel/header.js 27.58% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f98ae9...2cfdb2f. Read the comment docs.

Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me,

Please do note that we're very likely going to move the the content of the info addon into a panel.

@ndelangen
Copy link
Member

Thanks for this PR @uyeong !

@shilman
Copy link
Member

shilman commented Jun 23, 2017

Thanks @uyeong. The same problem was addressed in #1306, but that one is a little cleaner, so I merged it instead. Thanks for your contribution!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants