Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Run storybook in react@17 #12978

Merged
merged 8 commits into from
Nov 2, 2020
Merged

Build: Run storybook in react@17 #12978

merged 8 commits into from
Nov 2, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Nov 2, 2020

Issue: #12977

What I did

  • Update root package to allow react@17
  • Update react-testing-library

How to test

See CI, official-storybook

@shilman shilman added the maintenance User-facing maintenance tasks label Nov 2, 2020
@shilman shilman added this to the 6.1 core milestone Nov 2, 2020
@shilman shilman force-pushed the 12977-fix-official-storybook branch from e2cf51f to eb76a8f Compare November 2, 2020 05:56
@ndelangen
Copy link
Member

😭

ERROR in /tmp/storybook/lib/components/src/typography/DocumentFormattingSample.md
Module build failed (from /tmp/storybook/node_modules/babel-loader/lib/index.js):
SyntaxError: /tmp/storybook/lib/components/src/typography/DocumentFormattingSample.md: pragma and pragmaFrag cannot be set when runtime is automatic.
> 1 | 
    | ^
  2 | import React from 'react'
  3 | import { mdx } from '@mdx-js/react'
  4 | 
    at File.buildCodeFrameError (/tmp/storybook/node_modules/@babel/core/lib/transformation/file/file.js:250:12)
    at NodePath.buildCodeFrameError (/tmp/storybook/node_modules/@babel/core/node_modules/@babel/traverse/lib/path/index.js:163:21)
    at PluginPass.enter (/tmp/storybook/node_modules/@babel/helper-builder-react-jsx-experimental/lib/index.js:167:26)
    at newFn (/tmp/storybook/node_modules/@babel/core/node_modules/@babel/traverse/lib/visitors.js:175:21)
    at NodePath._call (/tmp/storybook/node_modules/@babel/core/node_modules/@babel/traverse/lib/path/context.js:55:20)
    at NodePath.call (/tmp/storybook/node_modules/@babel/core/node_modules/@babel/traverse/lib/path/context.js:42:17)
    at NodePath.visit (/tmp/storybook/node_modules/@babel/core/node_modules/@babel/traverse/lib/path/context.js:92:31)
    at TraversalContext.visitQueue (/tmp/storybook/node_modules/@babel/core/node_modules/@babel/traverse/lib/context.js:116:16)
    at TraversalContext.visitSingle (/tmp/storybook/node_modules/@babel/core/node_modules/@babel/traverse/lib/context.js:88:19)
    at TraversalContext.visit (/tmp/storybook/node_modules/@babel/core/node_modules/@babel/traverse/lib/context.js:144:19)
    at Function.traverse.node (/tmp/storybook/node_modules/@babel/core/node_modules/@babel/traverse/lib/index.js:82:17)
    at traverse (/tmp/storybook/node_modules/@babel/core/node_modules/@babel/traverse/lib/index.js:64:12)
    at transformFile (/tmp/storybook/node_modules/@babel/core/lib/transformation/index.js:107:29)
    at transformFile.next (<anonymous>)
    at run (/tmp/storybook/node_modules/@babel/core/lib/transformation/index.js:35:12)
    at run.next (<anonymous>)

@shilman shilman requested a review from aaronmcadam as a code owner November 2, 2020 09:35
@shilman
Copy link
Member Author

shilman commented Nov 2, 2020

self-merging @ndelangen -- thanks for the help on this

@shilman shilman merged commit 3775f57 into next Nov 2, 2020
@shilman shilman deleted the 12977-fix-official-storybook branch November 2, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants