Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshot testing inverse regex example documentation #1317

Merged
merged 1 commit into from
Jun 19, 2017

Conversation

epicallan
Copy link
Contributor

@epicallan epicallan commented Jun 18, 2017

Issue:

What I did

Added documentation about using inverse regex to exclude stories from snapshot testing following this issue #892 (comment)

How to test

@codecov
Copy link

codecov bot commented Jun 18, 2017

Codecov Report

Merging #1317 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1317   +/-   ##
=======================================
  Coverage   13.76%   13.76%           
=======================================
  Files         201      201           
  Lines        4620     4620           
  Branches      506      508    +2     
=======================================
  Hits          636      636           
- Misses       3538     3541    +3     
+ Partials      446      443    -3
Impacted Files Coverage Δ
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.78% <0%> (ø) ⬆️
addons/info/src/components/Props.js 0% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/left_panel.js 20% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 6.81% <0%> (ø) ⬆️
app/react/src/client/preview/init.js 0% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f98ae9...3761ebb. Read the comment docs.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tmeasday tmeasday merged commit 4b6a93a into storybookjs:master Jun 19, 2017
@epicallan
Copy link
Contributor Author

@tmeasday LGTM indeed and you are welcome. Thanks for all your work as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants