Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-backgrounds: Fix grid disable #13175

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Addon-backgrounds: Fix grid disable #13175

merged 1 commit into from
Nov 19, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Nov 19, 2020

Issue: #13173

What I did

Fix backgrounds grid disable

How to test

Couldn't repro, but this will probably fix it. Self-merging @yannbf

@shilman shilman requested a review from ndelangen as a code owner November 19, 2020 16:51
@shilman shilman added this to the 6.1 essentials milestone Nov 19, 2020
@shilman shilman merged commit cf9581e into next Nov 19, 2020
@shilman shilman deleted the 13173-fix-grid-disable branch November 19, 2020 16:52
@deep-cognite
Copy link

deep-cognite commented Nov 20, 2020

Thanks for this! Spent ages yesterday upgrading from v5 to v6 where I kept getting this error! From what I could tell, it happened if 'preview.js' didn't export 'parameters'.

Taking this message to pinpoint another thing that was bit "hard" to figure out during the transition from a custom webpack file to using main.js: and that was to add the custom plugins, as such:
webpackFinal: (config) => { return { ...config, plugins: [...config.plugins, ...custom.plugins], module: { ...config.module, rules: custom.module.rules } }; }

The example doesn't include 'plugins'

Also taking this comment to ask why under "About your Storybook" it says: "Storybook 6.1.0 is available. Upgrade from 6.1.0-rc.6 now." when I currently have 6.1.1 running 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants