Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Fix configFile: undefined in ts-loader options #13382

Merged

Conversation

earshinov
Copy link
Contributor

@earshinov earshinov commented Dec 5, 2020

Issue: #13381

What I did

Implemented the possible fix mentioned in the issue.

How to test

Please follow the repro steps in the issue.

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

@earshinov earshinov force-pushed the fix-tsloader-configfile-undefined branch from 500f040 to 3aeae08 Compare December 5, 2020 11:54
@earshinov
Copy link
Contributor Author

earshinov commented Dec 5, 2020

I'm not sure what to do with the failing "Dangerfile JS Pull / Danger JS (pull_request)". Please ping me if some action is required on my part.

Copy link
Contributor

@ThibaudAV ThibaudAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and it looks good to me

@shilman shilman changed the title [@storybook/angular] Fix configFile: undefined in ts-loader options when not using a custom .storybook/tsconfig.json Angular: Fix configFile: undefined in ts-loader options Dec 16, 2020
@shilman shilman added this to the 6.2 maintenance milestone Dec 16, 2020
@shilman shilman merged commit ce5d960 into storybookjs:next Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants