Enables Yarn 2 #13559
Enables Yarn 2 #13559
Conversation
|
What are those TeamCity tests? Can't see their content 🤔 |
|
@arcanis, you can login as a guest |
|
@arcanis I think you don't need to worry about the TeamCity tests for now, our "official" CI workflows are the ones from CircleCI. Plus, if I remember correctly I had some issue with them in a previous CI PR because there were always using workflow defined in |
|
I have just check out your branch locally, ran yarn install + build + test, and everything was ok 💪🏻 Doing the same in the CI executor (with ssh connection) and it's stuck after the resolution step (in the fetch step? 🤷🏻 ), maybe the current I'm really interested in this PR, feels free to ping me on discord if you want! |
|
Note for myself: As everything is working with Yarn 2 now, the Yarn 2 e2e tests must be reworked and renamed to Yarn PnP |
|
The e2e tests should probably avoid using npx as well, as that wont use the Yarn cache which will slow them down |
…a custom CLI For now, there is still a custom node script for a few weeks to still handle `yarn test --core` command. The `--puppeteer` option is now a standalone NPM script: `yarn test:puppeteer`. I also updated the CI jobs and the doc.
… command Also add `runInBand` and `ci` Jest options when running on CI.
gaetanmaisse
added
the
run e2e extended test suite
|
Closing in favour of smaller and more focused PRs:
|
What I did
Upgrading the Yarn binary to the latest stable release (2.4), which should make them faster.
I've configured the project to stay on the node_modules linker since it makes the upgrade fairly painless. Tests pass locally, I'll see how it goes on CI and tweak the command line references accordingly (things like
--frozen-lockfilebeing renamed to--immutable, etc).Notable changes:
The Yarn binary is checked within this repository. This mean that all your contributors will now be ensured to use the exact same version of Yarn, regardless what they have installed globally.
The root package.json now lists all workspaces as dependencies (using the
workspace:protocol). This is because in Yarn 2 the root workspace doesn't implicitly depend on all workspaces anymore, they have to be explicitly listed. In theory the dependencies should be listed in each workspace that depends on them (so for exampleuishould depend onapi) but I'm worried it would lead to a gigantic diff, so for now the repo keeps relying on the hoisting to work.How to test
The existing CI pipeline should be enough to validate that the upgrade is safe. One potential risky part is the publish workflow; I've heard it's already covered by tests using Verdaccio so it should be fine, but if someone can double check it would be perfect!