Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit storybook build non-zero on stats errors (e.g. errors in the transpilation pipeline) #1372

Merged
merged 4 commits into from
Jun 28, 2017
Merged

Exit storybook build non-zero on stats errors (e.g. errors in the transpilation pipeline) #1372

merged 4 commits into from
Jun 28, 2017

Commits on Jun 28, 2017

  1. fix: Fail on transpilation errors 

    Currently, storybook does not exit non-zero when there are errors in the pipeline, e.g. we are using TypeScript with `ts-loader` and a type error that fails tsc does not make storybook exit non-zero even though the transpilation failed.
    @joscha
    joscha committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    f3e7a0b View commit details
    Browse the repository at this point in the history

  2. Update build.js

    @joscha
    joscha committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    302f157 View commit details
    Browse the repository at this point in the history

  3. factor into one if

    @joscha
    joscha committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    9c57ae0 View commit details
    Browse the repository at this point in the history

  4. allow guard

    @joscha
    joscha committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    50aac05 View commit details
    Browse the repository at this point in the history