Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect preview- prefix #1375

Closed
wants to merge 1 commit into from
Closed

Conversation

rthor
Copy link

@rthor rthor commented Jun 28, 2017

The docs suggested an incorrect filename for custom head tags.

@codecov
Copy link

codecov bot commented Jun 28, 2017

Codecov Report

Merging #1375 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1375   +/-   ##
=======================================
  Coverage   14.35%   14.35%           
=======================================
  Files         201      201           
  Lines        4613     4613           
  Branches      506      504    -2     
=======================================
  Hits          662      662           
- Misses       3508     3521   +13     
+ Partials      443      430   -13
Impacted Files Coverage Δ
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
app/react/src/client/preview/client_api.js 39.28% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfa20f9...5d2d5e7. Read the comment docs.

@shilman
Copy link
Member

shilman commented Jun 28, 2017

@rthor preview-head.html is correct. head.html is also supported for backwards, compatibility, but is deprecated. it was renamed because we also added manager-head.html to add custom head tags for the whole storybook window instead of just the preview iframe.

If you're not seeing that perhaps you're using an older version of storybook?

@shilman
Copy link
Member

shilman commented Jun 29, 2017

@rthor closing this. please correct me if I got something wrong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants