Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): use theme input color for search focus bg #13792

Closed
wants to merge 1 commit into from
Closed

fix(ui): use theme input color for search focus bg #13792

wants to merge 1 commit into from

Conversation

jamime
Copy link

@jamime jamime commented Feb 2, 2021

Issue: #13388

What I did

I changed the Search component that is used in the sidebar to use the same color as form/Input, instead of the toolbar background color.

Theme Before After
light Screenshot 2021-02-02 at 15 34 25 Screenshot 2021-02-02 at 15 35 00
dark Screenshot 2021-02-02 at 15 34 32 Screenshot 2021-02-02 at 15 34 54

How to test

  1. Create a custom theme with a barBg prop.
import {create} from '@storybook/theming/create';

const light = create({
  base: 'light',
  barBg: 'hotpink',
});

const dark = create({
  base: 'dark',
  barBg: 'hotpink',
});
  1. Focus the Search component in the sidebar.
  • Is this testable with Jest or Chromatic screenshots? No.
  • Does this need a new example in the kitchen sink apps? No.
  • Does this need an update to the documentation? No.

@jamime jamime changed the title fix(components): use theme input color for search focus bg fix(ui): use theme input color for search focus bg Feb 2, 2021
@jamime
Copy link
Author

jamime commented Feb 15, 2021

Closing, fixed in #13895.

@jamime jamime closed this Feb 15, 2021
@shilman
Copy link
Member

shilman commented Feb 15, 2021

Argh, sorry I missed this @jamime 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants