Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs/Vue3: Resolve vue3 package for addon-docs preset #13819

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Addon-docs/Vue3: Resolve vue3 package for addon-docs preset #13819

merged 1 commit into from
Feb 5, 2021

Conversation

phated
Copy link
Contributor

@phated phated commented Feb 4, 2021

Issue: Pointed out at #13809 (comment)

What I did

I fixed a copy-paste issue with the vue 3 code in addon-docs.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@phated phated added the bug label Feb 4, 2021
@phated phated requested a review from shilman February 4, 2021 23:39
@shilman shilman added this to the 6.2 core milestone Feb 5, 2021
shilman
shilman approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@shilman shilman merged commit 411f94f into storybookjs:next Feb 5, 2021
@phated phated deleted the phated/vue3-addon-docs-fix branch February 5, 2021 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
addon: docs bug vue3
Projects
None yet
Milestone
6.2 core
Development

Successfully merging this pull request may close these issues.
2 participants
@phated @shilman