Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Add missing regenerator-runtime dependency #13916

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

gaetanmaisse
Copy link
Member

@gaetanmaisse gaetanmaisse commented Feb 15, 2021

Issue: #13830

What I did

  • Add missing regenerator-runtime dependency
  • Fix a typo in the E2E, for a few weeks the Yarn 2 PnP E2E tests were simply not running with Yarn 2.

How to test

  • CI should be 🟢
  • The logs in e2e-tests-yarn-2-pnp should match Yarn 2 ones

@gaetanmaisse gaetanmaisse added bug components patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 15, 2021
@gaetanmaisse gaetanmaisse marked this pull request as ready for review February 15, 2021 20:39
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaetanmaisse LGTM! 🙏 does this need to get patched back to master? i don't think so, so removing patch label. feel free to correct me if i'm wrong.

@shilman shilman removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Feb 16, 2021
@shilman shilman merged commit fdb1100 into next Feb 16, 2021
@shilman shilman deleted the fix/13830-add-missing-dep branch February 16, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants