CLI/Vue 2: install vue-loader upon init of vue 2 storybook #14018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #14011
What I did
I'm not sure if we should do this or not.
Essentially, the
@storybook/vue
package has a peerDep onvue-loader
and errors if someone doesn't install it (as was noted in the linked issue). It seems that some versions of the Vue CLI don't use webpack and don't install this dependency, so we could specify this as anextraPackages
so it is always installed bysb init
. Thoughts?How to test
If your answer is yes to any of these, please make sure to include it in your PR.