Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When timestamps are enabled, it actually checks them before applying changes #1405

Merged
merged 4 commits into from
Jul 22, 2017

Conversation

Gongreg
Copy link
Member

@Gongreg Gongreg commented Jul 4, 2017

Issue: Fixing PR I did #1039.

What I did

I accidentally added curly brace in wrong line. Because of that timestamps and debounce were actually not working properly, and first time user started typing text event still happened, even though it wasn't supposed to happen.

How to test

See #1039. Using the same examples (set timestamps true, and debounce to { wait: 1000, leading: true}.
Before this update first initial update would still kick in. After this update, debounce will work properly.

@codecov
Copy link

codecov bot commented Jul 4, 2017

Codecov Report

Merging #1405 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1405   +/-   ##
=======================================
  Coverage   14.54%   14.54%           
=======================================
  Files         202      202           
  Lines        4649     4649           
  Branches      500      572   +72     
=======================================
  Hits          676      676           
+ Misses       3555     3484   -71     
- Partials      418      489   +71
Impacted Files Coverage Δ
addons/knobs/src/components/Panel.js 88% <100%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 49.42% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 0% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
app/react/src/client/preview/render.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.81% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267ff2a...759313e. Read the comment docs.

@shilman shilman merged commit 63e4e41 into master Jul 22, 2017
@Hypnosphi Hypnosphi deleted the addon-knobs-performance branch August 17, 2017 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants