Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for sender on channel. #1407

Merged
merged 11 commits into from
Aug 28, 2017
Merged

Remove check for sender on channel. #1407

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
13e12da
Remove check for sender.
Gongreg Jul 4, 2017
6ae80e0
Merge branch 'master' into addons-channel-disable-owner-check
ndelangen Jul 5, 2017
ce4ea2d
Merge branch 'master' into addons-channel-disable-owner-check
ndelangen Jul 5, 2017
8ca620b
Fixed test.
Gongreg Jul 5, 2017
7558072
Merge branch 'master' into addons-channel-disable-owner-check
ndelangen Jul 6, 2017
cde8cf1
Merge branch 'master' into addons-channel-disable-owner-check
ndelangen Jul 24, 2017
568c675
Merge branch 'release/3.3' into addons-channel-disable-owner-check
shilman Aug 7, 2017
ac012fe
Merge branch 'release/3.3' into addons-channel-disable-owner-check
ndelangen Aug 23, 2017
64c2ce7
Merge branch 'release/3.3' into addons-channel-disable-owner-check
ndelangen Aug 24, 2017
6882c49
Merge branch 'release/3.3' into addons-channel-disable-owner-check
ndelangen Aug 25, 2017
3cc763b
Merge branch 'release/3.3' into addons-channel-disable-owner-check
ndelangen Aug 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/channels/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export default class Channel {

_handleEvent(event) {
const listeners = this._listeners[event.type];
if (event.from !== this._sender && listeners) {
if (listeners) {
listeners.forEach(fn => fn(...event.args));
}
}
Expand Down
4 changes: 2 additions & 2 deletions lib/channels/src/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,12 @@ describe('Channel', () => {
});

describe('_miscellaneous', () => {
it('should ignore if event came from itself', () => {
it('should not ignore if event came from itself', () => {
const received = [];
channel.on('type-1', n => received.push(n));
channel._handleEvent({ type: 'type-1', args: [11] });
channel._handleEvent({ type: 'type-1', args: [12], from: channel._sender });
expect(received).toEqual([11]);
expect(received).toEqual([11, 12]);
});
});
});