Verify that name is a string in addons/actions #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that it’s possible that `name` can be passed in as an object. In order for the `replace` method to work, name must be a string. This pull request adds a condition to the `fnName` constant that verifies the value of `name` is a string.
Codecov Report
@@ Coverage Diff @@
## master #1415 +/- ##
=======================================
Coverage 14.35% 14.35%
=======================================
Files 201 201
Lines 4612 4612
Branches 505 494 -11
=======================================
Hits 662 662
- Misses 3499 3526 +27
+ Partials 451 424 -27
Continue to review full report at Codecov.
|
ndelangen
approved these changes
Jul 6, 2017
|
Thank you for this PR @thomasthesecond ! Will run it locally and merge today! |
This was referenced Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Within addon/actions, it appears that it’s possible that
namecan be passed in as an object when a string is expected. This causes the error seen below in Chrome (version 59.0.3071.115):I’ve noticed that this error doesn’t always happen. If Storybook loads with a component that uses the action addon, there is no error. However, if you navigate to a component that uses the action addon, then the error appears.
What I did
This pull request adds a condition to the
fnNameconstant that verifies the value ofnameis a string.How to test
As I mentioned above, the error only seems to happen when you navigate to a component by clicking on its name from the menu.
I wanted to write a test for this, but wasn’t quite sure if the
fnNameconstant needs to be extracted from theactionfunction in order to make it testable.